Skip to content

Added support for CREATE DOMAIN #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 4, 2025
Merged

Added support for CREATE DOMAIN #1830

merged 5 commits into from
May 4, 2025

Conversation

LucaCappelletti94
Copy link
Contributor

This pull request adds support for the CREATE DOMAIN syntax and the tests to validate whether the implementation is correct. It closes issue #1829.

IMPORTANT: this pull request may collide with #1828, as I had to add the keyword DOMAIN in both of them.

Best,
Luca

@LucaCappelletti94
Copy link
Contributor Author

Refactored analogously to what was requested in pull request #1828

@LucaCappelletti94 LucaCappelletti94 requested a review from iffyio May 3, 2025 16:02
@iffyio iffyio changed the title Added support for CREATE DOMAIN and its test suite Added support for CREATE DOMAIN May 4, 2025
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @LucaCappelletti94!
cc @alamb

@iffyio iffyio merged commit ac1c339 into apache:main May 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants